Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix attn bias #1296

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Fix attn bias #1296

merged 1 commit into from
Aug 12, 2020

Conversation

eric-haibin-lin
Copy link
Member

Description

Fixes #1183 #1294
@davisliang @kaonashi-tyc

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@eric-haibin-lin eric-haibin-lin requested a review from a team as a code owner August 12, 2020 19:45
eric-haibin-lin
eric-haibin-lin commented Aug 12, 2020
View reviewed changes
Copy link
Member Author

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoisesHer would you inference graph pass PR by affected by this change?

@szha szha merged commit d75185e into dmlc:master Aug 12, 2020
@szha
Copy link
Member

szha commented Aug 12, 2020

@eric-haibin-lin thanks for the patch. shall we add this to v0.9.x?

@sxjscience sxjscience mentioned this pull request Aug 13, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-haibin-lin @szha